Fix PR#8061 SensorLib nRF ThinkNode M-series - #9084
Conversation
|
@WillyJL please review 🙏 |
|
i dont believe this is the optimal fix: these 2 devices include the library and define PCF8563_RTC, but do not define HAS_RTC. this means they do not actually query the RTC nor use it in any way from what i can understand of the code. this is similar to other things in #8061 where i removed PCF8563 and sensorlib from a lot of devices that included it but didnt use it, because they in fact do not have an RTC and it was just included as copy paste from other variant files. from what i can tell the correct fix here is to remove sonsorlib for these 2 variants aswell and remove the PCF8563_RTC from their variant.h files. |
|
of course its possible im misunderstanding the code, in that case updating like you did would work yes. but if these devices dont come with an rtc then no need to include the library |
6ca8b40 to
85941bc
Compare
I've modified this PR to remove rather than replace 👍 |
|
from a quick google it seems like thinknodes come with rtc, but i cant find any info on which rtc they use, and regardless for how the code was setup previously it was not in use anyway, i would assume more work would be needed to make it work. happy holidays! |
fifieldt
left a comment
There was a problem hiding this comment.
Maybe the lines should be commented with a link to this or other than removed ...
e427dba to
388367e
Compare
👍 done |
Addendum to meshtastic#8061 Try-fix Elecrow thinknode NRF M-series
388367e to
833dcf2
Compare
Addendum to #8061
Try-fix Elecrow thinknode NRF M-series.
lewisxhe/PCF8563_Libraryhas been replaced withlewisxhe/SensorLiband it seems just these two were missed.